wp-cli / core-command

Downloads, installs, updates, and manages a WordPress installation.
MIT License
49 stars 50 forks source link

wp core download crash when lastest WP version is not in the desired locale #240

Open neoteknic opened 1 year ago

neoteknic commented 1 year ago

Bug Report

_wp core download --locale=xxXX crash when lastest WP version is not in the desired locale

_wp core download && wp language core install frFR --activate is broken too (install ok but not the lang, switching to FR in admin break the website with sql errors)

Example

_wp --allow-root core download --locale=frFR --force crash with : Error: The requested locale (fr_FR ) was not found.

Temp fix force previous version

_wp --allow-root core download --locale=frFR --version=6.2.2 --force

Solution allow this command to download the lastest version (6.2.2, instead of 6.3 in the example) to use the desired locale. wp --allow-root core download --locale=fr_FR --force

or add a flag to allow downloading the previous working version.

danielbachhuber commented 1 year ago

Thanks for the report, @neoteknic !

This is a known issue that unfortunately occurs until the locale release is ready.

allow this command to download the lastest version (6.2.2, instead of 6.3 in the example) to use the desired locale. wp --allow-root core download --locale=fr_FR --force

or add a flag to allow downloading the previous working version.

I don't think we should automatically downgrade. Making it a specific opt-in behavior with a flag seems fine, though.

Feel free to submit a pull request, if you'd like. Here is some guidance on our pull request best practices.