search

wp-cli / dist-archive-command

Create a distribution .zip or .tar.gz based on a plugin or theme's .distignore file
https://developer.wordpress.org/cli/commands/dist-archive/
MIT License
47 stars 23 forks source link

Deal gracefully with symlinks #59

Closed BrianHenryIE closed 2 years ago

BrianHenryIE commented 2 years ago

Needs tests.

Has a nice test that fails on main and passes with this PR.

Fixes #57

schlessera commented 2 years ago

@BrianHenryIE Now that I'm looking at the code again with fresh eyes... is there a reason why you're using closures in the first place? These two closures should rather be private methods of the class...

BrianHenryIE commented 2 years ago

Not particularly. Probably because there's no PHPUnit tests needing them be callable functions.

Why private instead of protected? static still?

danielbachhuber commented 2 years ago

Ship #61