Closed BrianHenryIE closed 2 years ago
@BrianHenryIE Now that I'm looking at the code again with fresh eyes... is there a reason why you're using closures in the first place? These two closures should rather be private methods of the class...
Not particularly. Probably because there's no PHPUnit tests needing them be callable functions.
Why private
instead of protected
? static
still?
Ship #61
Needs tests.Has a nice test that fails on main and passes with this PR.
Fixes #57