Open lkraav opened 4 years ago
wp option list
ignores transients by default, but they can be included with the --transients
argument. It doesn't have an option to include both options and transients though, so the easiest way to solve this is by running two commands here in wp doctor check autoload-options-size
:
wp option list --autoload=on
wp option list --transients --autoload=one
Then simply add the numbers together.
Transients are conceptually separate from options, even though they're stored in the same location, so I think this would be better implemented as a new transients-size
check.
Bug Report
Describe the current, buggy behavior
wp doctor check autoload-options-size
- 650 kBSELECT 'Autoload kiB' as name, ROUND(SUM(LENGTH(option_value)) / 1024) as value FROM wp_options WHERE autoload='yes'
- 2.4 MBDifference is in counting
_transient_*
options.https://codex.wordpress.org/Function_Reference/set_transient#Notes points out "NB: transients that never expire are autoloaded, whereas transients with an expiration time are not autoloaded. Consider this when adding transients that may not be needed on every page, and thus do not need to be autoloaded, impacting page performance."
Describe what you would expect as the correct outcome
wp doctor check autoload-options-size
should count unexpirable transients.Let us know what environment you are running this on
Reading https://github.com/wp-cli/doctor-command/pull/15/files by @danielbachhuber I'm now thinking this may be an issue for
wp option
command instead. Your thoughts?