wp-cli / entity-command

Manage WordPress comments, menus, options, posts, sites, terms, and users.
MIT License
100 stars 90 forks source link

Use `RecursiveDataStructureTraverser` from `wp-cli` package #435

Closed thelovekesh closed 8 months ago

thelovekesh commented 11 months ago

Feature Request

For reuse elsewhere, the RecursiveDataStructureTraverser and NonExistentKeyException classes(currently part of this package) have been moved to the wp-cli package in https://github.com/wp-cli/wp-cli/pull/5864.

Once these changes are live, we can safely deprecate or extend the logic from wp-cli package.

See https://github.com/wp-cli/wp-cli/issues/5837

danielbachhuber commented 11 months ago

We'll need to hold off on this until WP-CLI 2.10.0 (or 3.0.0) is released.

thelovekesh commented 8 months ago

Since this has landed in the WP CLI 2.10.0 release and was fixed in https://github.com/wp-cli/entity-command/pull/442 for comptaibility, I am closing this as done.