wp-cli / entity-command

Manage WordPress comments, menus, options, posts, sites, terms, and users.
MIT License
100 stars 89 forks source link

Add commands for managing signups on multisite #489

Closed ernilambar closed 4 months ago

ernilambar commented 6 months ago

Adds signup command and subcommands

Command details: https://github.com/ernilambar/entity-command/tree/feat-signup#wp-signup

Related: https://github.com/wp-cli/wp-cli/issues/1911

PR inspired from https://github.com/trepmal/wp-cli-unconfirmed-users

Highlights:

ernilambar commented 5 months ago

Note:

tyrann0us commented 5 months ago

Hi @danielbachhuber, to continue our conversation from https://github.com/wp-cli/wp-cli/issues/1911, would you consider this PR ready? Thanks!

swissspidy commented 4 months ago

@ernilambar I just merged https://github.com/wp-cli/wp-cli/pull/5926 now

To make the PR work now, update composer.json here to require "wp-cli/wp-cli": "^2.11"

swissspidy commented 4 months ago

I don't understand the test failures, they look unrelated 🤔

ernilambar commented 4 months ago

I don't understand the test failures, they look unrelated 🤔

Yah, there are no changes related to taxonomies here.

swissspidy commented 4 months ago

Ah, when I try locally I get this:

$ WP_VERSION=trunk composer behat features/taxonomy.feature:7
> run-behat-tests 'features/taxonomy.feature:7'
-----

--- Failed hooks:

    BeforeSuite # WP_CLI\Tests\Context\FeatureContext::prepare()
      $ wp cli info

      Error: Callable "Signup_Command" does not exist, and cannot be registered as `wp user signup`.
      cwd: 
      run time: 0.16830706596375
      exit status: 1 (RuntimeException)

Edit: just needed to run composer update

swissspidy commented 4 months ago

As just discussed on the Zoom call, it's because of https://github.com/wp-cli/wp-cli/pull/5928

We'll fix this separately.

swissspidy commented 4 months ago

https://github.com/wp-cli/wp-cli/pull/5928 has been reverted in the meantime

johnbillion commented 4 months ago

See also https://github.com/wp-cli/ideas/issues/99