wp-cli / extension-command

Manages plugins and themes, including installs, activations, and updates.
MIT License
90 stars 79 forks source link

Fix: failing tests "Branch names should be removed from Github projects" on PHP 5.6 #301

Closed Nikschavan closed 3 years ago

Nikschavan commented 3 years ago

Bug Report

Describe the current, buggy behavior

First reported in https://github.com/wp-cli/extension-command/pull/300#issuecomment-938755216, The behat tests are failing in WordPress 5.6 because the plugin one-time-login is being downloaded in the tests which requires PHP 7.1

Describe how other contributors can replicate this bug

Describe what you would expect as the correct outcome No failing tests.

Provide a possible solution

A simple repo, preferably in wp-cli organisation with just the plugin header can be used in the tests so that this error will not happen in future.