search

wp-cli / extension-command

Manages plugins and themes, including installs, activations, and updates.
MIT License
90 stars 79 forks source link

Add title/description for mu-plugins. #305

Closed alexstine closed 2 years ago

alexstine commented 3 years ago

Currently, only name is populated for mu-plugins. This PR will also fill in the title and add the description.

schlessera commented 3 years ago

Thanks for the PR, @alexstine !

The code looks good at first glance, but to merge it, we'd need a Behat test as well to ensure it actually does (and keeps doing) what it is supposed to do. Do you care to add such a test?

alexstine commented 2 years ago

@schlessera Can you find another contributor to implement the test? I just don't have time at the moment and I'm sure you are probably in the same boat. Maybe one for next CLI meeting?

Thanks.

wojsmol commented 2 years ago

@alexstine Changes reverted in https://github.com/wp-cli/extension-command/pull/305/commits/10b75d3255ab349541d51965564d7bb04f3964bf was correct.

alexstine commented 2 years ago

@wojsmol Better now? Just refreshed the fork/branch.

wojsmol commented 2 years ago

@alexstine LGTM now. Tests are requiring @schlessera approval to run.

alexstine commented 2 years ago

@wojsmol These check fails don't look related to my changes. Maybe worth a re-run?

swissspidy commented 2 years ago

Should we also add support for descriptions?

Tests are all passing now btw

alexstine commented 2 years ago

Nothing like all green checks. 👍

If you think it is a good idea, I can try to get descriptions working or can handle in another PR.

swissspidy commented 2 years ago

If you're up for it, that would be great. Can be in this PR or a new one, whatever works best for you. Code-wise it should be mostly copy & paste

alexstine commented 2 years ago

@swissspidy Done. Not sure if the tests will pass but hopefully so. Gave this a test on my test server, seems solid enough.