search

wp-cli / extension-command

Manages plugins and themes, including installs, activations, and updates.
MIT License
90 stars 79 forks source link

Don't report an error when 5 out of 5 plugins were updated #338

Closed akirk closed 2 years ago

akirk commented 2 years ago

Currently, if you've got (unreleased) plugins with an unexpected version they are skipped but this skipping is recorded in a wrong way resulting in a summary output that says Error: Only updated 5 of 5 plugins.

Before

Screenshot 2022-11-09 at 11 41 46

After

Screenshot 2022-11-09 at 11 42 27
akirk commented 2 years ago

I've added a behat test and fixed the phpcs, could you kick off the workflow again? Thanks!

danielbachhuber commented 2 years ago

@akirk Yep! Looks like the sed doesn't quite work, and there are a couple other tests failing as the result of the change:

image
danielbachhuber commented 2 years ago

@akirk Any ideas what this last failure might be?

akirk commented 2 years ago

Struggling to understand the failure, it runs fine for me locally.

composer behat -- features/plugin-update.feature
> run-behat-tests 'features/plugin-update.feature'
...................................................................... 70
..............................

9 scenarios (9 passed)
100 steps (100 passed)
0m50.86s (11.16Mb)

composer behat -- features/plugin.feature
> run-behat-tests 'features/plugin.feature'
...................................................................... 70
...................................................................... 140
...................................................................... 210
....................................

22 scenarios (22 passed)
246 steps (246 passed)
1m42.79s (11.20Mb)
akirk commented 2 years ago

Oh it fails on PHP 5.6.

danielbachhuber commented 2 years ago

Oh it fails on PHP 5.6.

@akirk It also looks like it's been failing on master for a while: https://github.com/wp-cli/extension-command/actions/runs/3338955722/jobs/5527290587

Thanks again for your work on this!