Closed sejas closed 8 months ago
Thanks for the quick review! I fixed the alignment issues (https://github.com/wp-cli/extension-command/pull/380/commits/1335956354f1658595e568ed2335e5f0517d01a4). I also updated some comments on the functions. (https://github.com/wp-cli/extension-command/pull/380/commits/7fb9b9bdec5a4eb2eab98bfc73cc5d74028b93e6)
And I realized that the json
format is returning null instead of an empty string. Is that something I need to change?
I would appreciate where that part of the code lives.
wp plugin list --format=json
[
{"name":"akismet","status":"active","update":"none","version":"5.3","update_version":null}
,{"name":"hello","status":"inactive","update":"none","version":"1.7.2","update_version":null}
,{"name":"Zombieland","status":"inactive","update":"none","version":"0.1.0","update_version":null}
,{"name":"no-mail","status":"must-use","update":"none","version":"","update_version":null}
,{"name":"polyfills","status":"must-use","update":"none","version":"","update_version":null}
]
The table, and csv format are working correctly returning an empty string.
I'll also solve the merging conflicts.
And I realized that the json format is returning null instead of an empty string. Is that something I need to change? I would appreciate where that part of the code lives.
I found it: https://github.com/wp-cli/extension-command/pull/380/commits/9749bd2a293c12609ef4df95741453438e9029d1
Description
I'm adding the field
update_version
as a default field forplugin
andtheme
commands. If noupdate_version
is available we return an empty string following the same pattern asversion
itself.Now
wp plugin list
andwp theme list
display a table similar to:Testing instructions
composer behat -- features/plugin-update.feature
composer behat -- features/plugin.feature
composer behat -- features/upgradables.feature
composer behat -- features/theme.feature