Open salcode opened 1 year ago
@salcode Did you want to submit a PR for this?
I don't anticipate submitting a PR for this in the immediate future due to a combination of this change being more complex than I additionally identified and my current time limitations.
While I still think removing hub
as a requirement is a good move to make and hope to ultimately revisit this, I understand if you want to close this issue for the time being.
hub
As I started writing up changes, I realized how powerful the hub
tool is.
For example this line
run hub fork here to create a pushable repository on GitHub.
encompasses a lot of changes in a simple command. It is non-trivial to replace this line.
I still think we should remove hub
as a dependency however it brings up the question of how to document this. Do we:
a. Expect a certain level of knowledge around using Git and remotes (e.g. "Create a fork of the repository and update your remote to push your changes to the newly forked repo") b. Link to an external resource which explains how to fork a project and update your remote c. Including all of the information about how to visit the GitHub repo (e.g. something like
While hub
abstracts away all of these changes, this abstraction feels like a layer of "magic" that prevents the user from understanding what is going on.
Feature Request
Currently, https://make.wordpress.org/cli/handbook/contributions/pull-requests/ indicates
hub
is a required tooland some commands are
hub
specific, e.g.Proposed Solution
Modify the language and example commands to use
git
commands directly, rather thanhub
.Optionally, call out
hub
as a useful tool that can be used.Possible Drawbacks