search

wp-cli / i18n-command

Provides internationalization tools for WordPress projects.
MIT License
96 stars 52 forks source link

119 Filename before the warning and full path to it #361

Open elenachavdarova opened 1 year ago

elenachavdarova commented 1 year ago

Included full path to the file and moved the path in the start of the warning.

Fixes: https://github.com/wp-cli/i18n-command/issues/119

elenachavdarova commented 1 year ago

Hello @danielbachhuber, Thank you for your reply. For the full path - my opinion is that relative is better as well, however on the issue this PR is for - https://github.com/wp-cli/i18n-command/issues/119 the request is for full path (especially when automating). This is why I have set this up this way.

As for the funcitonal tests - I checked the errors upon the failed tests and I am not sure how to include the full path (as it is a tmp one) to the expected output. I have updated the PR with file name moved to the start of the error.

danielbachhuber commented 1 year ago

Thank you for your reply. For the full path - my opinion is that relative is better as well, however on the issue this PR is for - #119 the request is for full path (especially when automating). This is why I have set this up this way.

@elenachavdarova Sounds good!

As for the funcitonal tests - I checked the errors upon the failed tests and I am not sure how to include the full path (as it is a tmp one) to the expected output. I have updated the PR with file name moved to the start of the error.

This works for me.

I'll leave this to @swissspidy for a final review. He's AFK for the next week or so though, so it might be a little bit.