wp-cli / i18n-command

Provides internationalization tools for WordPress projects.
MIT License
96 stars 52 forks source link

Update `theme-i18n.json` #366

Closed swissspidy closed 9 months ago

swissspidy commented 1 year ago

~We really need a better way to keep this file in sync with core.~ Edit: forgot that we fetch directly from svn

swissspidy commented 1 year ago

cc @oandregal @gziolo if you could help me double check this

oandregal commented 1 year ago

I've compared the changes with core and it looks good. I'm trying to find the tests instructions in older PRs.

oandregal commented 1 year ago

This is what I've done for testing (updated from https://github.com/wp-cli/i18n-command/pull/306):

oandregal commented 1 year ago

I've also run composer behat -- features/makepot.feature though the scenario 001 Scenario: Extract all supported functions failed. Same as in trunk, so unrelated to this PR.

swissspidy commented 1 year ago

Awesome, thanks for testing! 🎉

Totally forgot that this is just the backup file. That makes the change way less urgent 🙂

I'll see if I can reproduce that test failure locally.

schlessera commented 11 months ago

We really need a better way to keep this file in sync with core.

We can add a GHA that replaces the included file with the one on SVN and creates a PR if changes have been detected.

swissspidy commented 9 months ago

@schlessera Good idea. Just added such a workflow now.