search

wp-cli / i18n-command

Provides internationalization tools for WordPress projects.
MIT License
96 stars 52 forks source link

Revert changes to extract title from styles.blocks.variations #407

Closed oandregal closed 1 month ago

oandregal commented 1 month ago

What

This PR reverts https://github.com/wp-cli/i18n-command/pull/405

Why

https://github.com/wp-cli/i18n-command/pull/405 introduced the ability to extract strings (title) from the property styles.blocks.variations of the theme.json — these were missing and detected during the beta period.

Later on, the feature received more feedback and the consensus was to remove the ability to register block style variations from theme.json. That together with some changes to the shape of the styles subtree, made https://github.com/wp-cli/i18n-command/pull/405 unnecessary, as there is no longer a title key to translate.

How

Revert the changes introduced in #405

Test

Automated test should pass. They are now broken in main. See setup instructions at https://github.com/wp-cli/i18n-command/pull/405

composer install
composer behat -- features/makepot.feature
oandregal commented 1 month ago

cc @aaronrobertshaw for awareness (nothing to do).