Closed ramonjd closed 1 month ago
I approved the core PR and this PR is also working well for me.
I'll leave @swissspidy comment on this, but my understanding is that we should merge the core PR and right after merge this one.
Correct. Otherwise tests are failing, as you can see now :-)
The core PR has been merged as of https://github.com/WordPress/wordpress-develop/commit/2930212ff6bf6619d026f525ceab2719c5229597
Thanks for the help, folks 🙇🏻
This PR:
TODO
Context
A "description" key was added to theme.json in https://github.com/WordPress/gutenberg/pull/45242
The Gutenberg PR was synced to Core in https://github.com/WordPress/wordpress-develop/pull/4687
Unfortunately, a corresponding entry to the theme.json i18n schema was not part of the change.
Core trac ticket: https://core.trac.wordpress.org/ticket/61543
Testing
Set up
Before running any of the test (manual or automatic), make sure to set the
THEME_JSON_SOURCE
to '' (empty string) so theThemeJsonExtractor
picks the the local backup file with the changes atassets/theme-i18n.json
.Automated tests:
Manual tests:
Create a new directory called
foo-theme
that contains a theme.json file with the following contents:Run
vendor/bin/wp i18n make-pot foo-theme
Verify that there's a
foo-theme/foo-theme.pot
file and that the "My style variation description" string is present as well as its context "Style variation description".You should see something like: