Don't use WP_CLI::error() when installing translations for multiple locales

wp-cli / language-command

Installs, activates, and manages language packs.

MIT License

13 stars 21 forks source link

Don't use WP_CLI::error() when installing translations for multiple locales #61

Closed ocean90 closed 5 years ago

ocean90 commented 5 years ago

This is about https://github.com/wp-cli/language-command/blob/f71622d223226e1d738f1f1a645c47d73cb921e5/src/Plugin_Language_Command.php#L212-L225

Example command: wp language plugin install <plugin-name> de_DE de_CH When the installation of de_DE fails the command should continue to install de_CH. The failed installation should be documented as warning. This would be similar to the media regenerate command which uses Utils\report_batch_operation_results().

schlessera commented 5 years ago

Yes, seems that this would be more consistent to what other similar commands are doing.

Are you up for providing a PR for this?

ocean90 commented 5 years ago

Started in https://github.com/wp-cli/language-command/pull/63.

ocean90 commented 5 years ago

If #63 looks good we should probably do the same for the uninstall commands.