search

wp-cli / language-command

Installs, activates, and manages language packs.
MIT License
13 stars 21 forks source link

`language plugin list` for bad plugin slugs should throw warning #86

Closed vielhuber closed 1 year ago

vielhuber commented 5 years ago

Hello!

When I type

wp language plugin list foobar

I always get an output:

image

I can write anything I want:

image

This should not be the case :-)

janw-me commented 2 years ago

A candidate for good-first-issue ?

Should return a nice error.

schlessera commented 2 years ago

Ah, it looks like this is a combination of the command not checking for the plugin's existence and WP Core always having a default language for anything.

I guess we should throw warnings for missing plugins and skip them, which would then end up with an empty list if no valid plugin slugs were provided.

GeoJunkie commented 1 year ago

I'll take a look at this