search

wp-cli / language-command

Installs, activates, and manages language packs.
MIT License
13 stars 21 forks source link

Clarify docs arugment #90

Closed timotheemoulin closed 4 weeks ago

timotheemoulin commented 4 years ago

Can we update the example in the doc and add one with the full locale? I think that could help.

e.g.

wp language core install fr_FR

or at least write something in the options section under the <language> chapter.

danielbachhuber commented 1 year ago

@timotheemoulin I'm not sure I understand your suggestion... want to submit a pull request with your suggested change?

ernilambar commented 3 months ago

@danielbachhuber

Let me jot down my understanding here.

https://developer.wordpress.org/cli/commands/language/core/install/ - wp language core install <language>... [--activate]

<language> - Language code to install.

We have mentioned language code. But in our WordPress context, Language Code is different than WordPress Locale Code.

For Nepali language, language code is ne but WP locale code is ne_NP. But some languages have same language code and locale code like ja, ar, etc.

In our docs, it is not particularly clear that we should use ne_NP instead of ne. In the example also, we have used Japanese which coincidently happens to have same language code and locale code. So I believe OP is asking to clarify this confusion in the docs and examples.

danielbachhuber commented 3 months ago

@ernilambar Thanks for clarifying — that makes sense!

UmeshSingla commented 2 months ago

Working on it.

swissspidy commented 4 weeks ago

Fixed by #153