Open kraftner opened 4 months ago
The problem seems to be that when generating the attachment meta data
this always results in the creation of sub sizes
Looking at the logic in wp_create_image_subsizes()
it seems that this could be disabled by temporarily disabling auto-downscale and auto-rotate with something like this:
add_filter('big_image_size_threshold', '__return_false');
add_filter('wp_image_maybe_exif_rotate', '__return_false');
Thanks for the great report, @kraftner !
Feel free to submit a pull request, if you'd like. Here is some guidance on our pull request best practices.
@danielbachhuber Due to my current workload you probably shouldn't hold your breath for that. That is why I did my best to at least document it in case someone else can beat me to it earlier.
In any case I think there needs to be some more thinking about when/how to disable it, how to handle the case that someone wants to regenerate those files etc.
Today I had some minutes to look at this some more. This particular issue can be solved by adding this
// For auto-downscaled images
$image_size_filters['big_image_size_threshold'] = '__return_false';
// For auto-rotated images
$image_size_filters['wp_image_maybe_exif_rotate'] = '__return_false';
But it made me realize that the regeneration of these images is a more general and bigger issue and also can be a problem when regenerating everything and not just one size because then one might run into #136.
So I am leaving this here, but the whole issue needs some more investigation that also considers #136 and has extensive test coverage for all edge cases so I don't deem this ready for a PR yet.
Bug Report
Describe the current, buggy behavior
In WP 5.3 two new features for uploaded images got introduced:
Unfortunately for any image affected by the above feature when regenerating any thumbnail size that auto-generated image gets regenerated as well. So even if you use
wp media regenerate --image_size=<image_size>
.Under most circumstances this will just recreate an already existing image and won't cause any serious harm.
But it's still not ideal for at least these reasons:
I've noticed these unexpected changes while desperately attempting to understand what happened during a completely botched media regeneration caused by #130, #136 and this very issue.
Describe how other contributors can replicate this bug
-scaled.jpg
wp media regenerate <attachment-id> --image_size=medium
-scaled.jpg
file in the filesystem has changed to the time you ran the above commandAn alternative approach to test this in a visually noticeable way is to add this snippet in a plugin or themes
functions.php
between the initial upload and the regeneration. (It reduces the JPEG quality of generated images to "terrible")After the regeneration you should be able to notice that the intentionally regenerated "medium" size thumbnail has terrible compression artifacts, but the
-scaled.jpg
unexpectedly also has.Describe what you would expect as the correct outcome
When limiting the media regeneration to a specific image size I expect any other images to be unaffected.
Let us know what environment you are running this on
WordPress 6.4.3