search

wp-cli / php-cli-tools

A collection of tools to help with PHP command line utilities
MIT License
676 stars 118 forks source link

PHP 8.2: strwidth() & Colors::pad()/decolorize() should always work with a string #163

Closed slaFFik closed 1 year ago

slaFFik commented 1 year ago

Fix #162

swissspidy commented 1 year ago

Only had a quick glance, but can‘t we fix the calling code instead?

slaFFik commented 1 year ago

I think we can, but it's like a dozen places all over the place :) Also, those methods are public static, so can (and are) be used by someone else - and the fix of the calling code won't do anything for them.

So I do believe these methods should be adjusted (perhaps together with the calling code as well).