search

wp-cli / php-cli-tools

A collection of tools to help with PHP command line utilities
MIT License
673 stars 118 forks source link

Table::getDisplayLines() should not output excessive lines when no rows #165

Open slaFFik opened 1 year ago

slaFFik commented 1 year ago

Fix #164.

slaFFik commented 1 year ago

Yes, sure, I will try to do that today/tomorrow. Sorry for missing them (was in jeopardy when creating this PR and forgot to check the checks' status, my bad).

slaFFik commented 1 year ago

@danielbachhuber, test Test_Table_Ascii::testDrawWithHeadersNoData() fixed, all checks are 🍏.

danielbachhuber commented 1 year ago

@slaFFik What do you think about avoiding the back compat break? https://github.com/wp-cli/php-cli-tools/issues/164#issuecomment-1740990717