PHP Deprecated: Creation of dynamic property cli\arguments\HelpScreen::$_flagMax is deprecated

[kodie]

Bug Report

• [X] Yes, I reviewed the contribution guidelines.
• [X] Yes, more specifically, I reviewed the guidelines on how to write clear bug reports.

Describe the current, buggy behavior

While running the "arguments" example on PHP v8.2.1 and passing the "help" option, the following errors occur:

PHP Deprecated:  Creation of dynamic property cli\arguments\HelpScreen::$_flagMax is deprecated in /Users/kodiegrantham/www/misc/fss-cli/vendor/wp-cli/php-cli-tools/lib/cli/arguments/HelpScreen.php on line 43

Deprecated: Creation of dynamic property cli\arguments\HelpScreen::$_flagMax is deprecated in /Users/kodiegrantham/www/misc/fss-cli/vendor/wp-cli/php-cli-tools/lib/cli/arguments/HelpScreen.php on line 43
PHP Deprecated:  Creation of dynamic property cli\arguments\HelpScreen::$_optionMax is deprecated in /Users/kodiegrantham/www/misc/fss-cli/vendor/wp-cli/php-cli-tools/lib/cli/arguments/HelpScreen.php on line 50

Deprecated: Creation of dynamic property cli\arguments\HelpScreen::$_optionMax is deprecated in /Users/kodiegrantham/www/misc/fss-cli/vendor/wp-cli/php-cli-tools/lib/cli/arguments/HelpScreen.php on line 50

These errors don't show up on PHP v8.0.30

Describe how other contributors can replicate this bug

• cd php-cli-tools/examples
• ./arguments help

[swissspidy]

Looks like a simple oversight where the property has the wrong name here, it should be flagMax:

https://github.com/wp-cli/php-cli-tools/blob/8ffd0cfc17bd2f27a96d8a80609aaa656b4418c6/lib/cli/arguments/HelpScreen.php#L22

Ditto for optionMax / maxOption:

https://github.com/wp-cli/php-cli-tools/blob/8ffd0cfc17bd2f27a96d8a80609aaa656b4418c6/lib/cli/arguments/HelpScreen.php#L24

Would you be up for submitting a PR that renames them?

[kodie]

@swissspidy PR made!