Closed swissspidy closed 3 months ago
@swissspidy It seems like on local, tests autoloading has no effect. Tests are running on local even when I disable this line
Can I send some tests commits to this PR?
Yes I noticed that too, but no idea why.
And the error message on CI don't seem to make sense either
PHP Warning: Uncaught require(/home/runner/work/php-cli-tools/php-cli-tools/lib/cli/Table/Ascii.php): failed to open stream: No such file or directory
/home/runner/work/php-cli-tools/php-cli-tools/tests/bootstrap.php:19
/lib/cli/Table/Ascii.php
does exist
Error message have Table
in the path while the directory name is table
.
├── table
│ ├── Ascii.php
│ ├── Renderer.php
│ └── Tabular.php
That was it! Thanks @thelovekesh!
Still a mystery to me, why it was not reproducible on my local 🤔. I guess it has something to do with tests custom autoloader.
Case insensitive filesystem I suppose
Trying to fix tests after https://github.com/wp-cli/wp-cli-tests/pull/206
I realized we were not actually running tests against PHP 5.3, only 5.6+, so I figured we can just bump the requirement while at it.
To-do: