search

wp-cli / php-cli-tools

A collection of tools to help with PHP command line utilities
MIT License
674 stars 118 forks source link

Escape % characters in table output properly. Fixes #86 #87

Closed leewillis77 closed 8 years ago

danielbachhuber commented 9 years ago

Is it possible to add some test coverage for this?

leewillis77 commented 9 years ago

Hi Daniel;

Happy to look at that. Are you looking for test coverage in wp-cli - or in php-cli-tools? I'm struggling to work out where the tests would be - test-table-ascii.php looks like the closest candidate, but I'm not sure that it's doing the same thing as WP-CLI does - at least my tests (See updated PR) aren't doing what I'd expect.

danielbachhuber commented 9 years ago

Are you looking for test coverage in wp-cli - or in php-cli-tools?

php-cli-tools

I'm struggling to work out where the tests would be

You're welcome to create a new file for it.

danielbachhuber commented 8 years ago

Closing in favor of #91