search

wp-cli / profile-command

Quickly identify what's slow with WordPress
MIT License
266 stars 29 forks source link

Move command over to new v2 structure #151

Closed wojsmol closed 5 years ago

wojsmol commented 6 years ago

fixes https://github.com/wp-cli/profile-command/issues/150

wojsmol commented 6 years ago

@GaryJones Plese take a look on phpcs errors here and give me a hint how to solve them.

GaryJones commented 6 years ago

Variable variables can typically be fixed by making $$key into ${$key} though I've not looked at the logic in this package.

Reported violations about siliencing errors, and eval, if it's right for them to be ignored, can be hidden by the use of the // phpcs:ignore Name.Of.Sniff.Error -- for reasons-format comment on the same line as the violation, or as the only comment on the line before it.

wojsmol commented 6 years ago

https://travis-ci.org/wp-cli/profile-command/jobs/414874921 - this is php 7.2 incompatibility https://travis-ci.org/wp-cli/profile-command/jobs/414874922 and others to proper table produced.