Remove default value from $include_total

wp-cli / profile-command

Quickly identify what's slow with WordPress

MIT License

266 stars 29 forks source link

Remove default value from $include_total #162

Closed TimothyBJacobs closed 3 years ago

TimothyBJacobs commented 3 years ago

This parameter isn't actually optional because it is followed by required parameters. This issues a warning on PHP 8.

Deprecated: Required parameter $order follows optional parameter $include_total in /Users/timothybjacobs/Workspace/wp-cli-dev/profile-command/inc/class-formatter.php on line 45

schlessera commented 3 years ago

Remaining test breakage seems to be for old versions of WP only, ignoring for now to move forward with PHP 8 support.