search

wp-cli / scaffold-command

Generates code for post types, taxonomies, blocks, plugins, child themes, etc.
MIT License
165 stars 87 forks source link

child-theme throws an error if the --path argument is set #251

Open michaelandre0 opened 4 years ago

michaelandre0 commented 4 years ago

Bug Report

I am trying to create a child theme using the following command:

wp scaffold child-theme child-slug --parent_theme=parent-slug --theme_name="My child theme" --activate --path=../mywpsite/

It then throws this error:

Error: Invalid theme slug specified. The target directory '/home/clients/0000000000/myfolder/../mywpsite/wp-content/themes/child-slug' is not in '/home/clients/0000000000/myfolder/../mywpsite/wp-content/themes'.

However, if I execute the command directly from the ~/mywpsite/ folder, it works fine, but the folder has to exist before or I get the following error.

Success: Created '/home/clients/0000000000/mywpsite/wp-content/themes/child-slug'. Error: The theme directory "child-slug" does not exist.

BUT, the folder AND files still have been created.

That being said, I need to have it work with the --path argument, so I'm assuming this is a bug.

How can this be fixed ?

Thank you

NickStallman commented 4 years ago

Just noticed that this issue is the same as mine. https://github.com/wp-cli/scaffold-command/issues/263

There is a str_replace line that needs to be wrapped with realpath to fix the issue.

swissspidy commented 1 year ago

Looks like this is still relevant, but the attached PR got closed by accident.

It could be restored from https://gist.github.com/danielbachhuber/2951826b5cee4db3c8245ff095d5b7de though.

@NielsdeBlaauw would you be interested in giving this another go?

ernilambar commented 7 months ago

In this issue, are we talking about Windows setup? In Mac, I am not being able to reproduce the mentioned issue.

michaelandre0 commented 7 months ago

In this issue, are we talking about Windows setup? In Mac, I am not being able to reproduce the mentioned issue.

Since I posted this, and considering how the paths look like I would say it wasn't a Windows environment but I can't remember for sure since it was 4 years ago. However I do use Windows for many devs and it could be a possibility.

sarahschopick commented 5 months ago

I keep getting an error message that I need to install the parent theme, even though the parent theme is already installed.

ernilambar commented 5 months ago

@sarahschopick Is it possible to provide detailed steps to reproduce the issue? And also your setup environment info. Asking because we are not being able to reproduce issue in our local setup.