search

wp-cli / scaffold-command

Generates code for post types, taxonomies, blocks, plugins, child themes, etc.
MIT License
165 stars 86 forks source link

Scaffold theme test should work in PHP greater than 8.0 #334

Closed ernilambar closed 5 months ago

ernilambar commented 5 months ago

This PR removes following code from theme-bootstrap.mustache:

if ( PHP_MAJOR_VERSION >= 8 ) {
    echo "The scaffolded tests cannot currently be run on PHP 8.0+. See https://github.com/wp-cli/scaffold-command/issues/285" . PHP_EOL; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
    exit( 1 );
}

While working on https://github.com/wp-cli/scaffold-command/pull/331 I noticed this conditional is now not needed.

CC @schlessera - Ref https://github.com/wp-cli/scaffold-command/issues/285