search

wp-cli / scaffold-command

Generates code for post types, taxonomies, blocks, plugins, child themes, etc.
MIT License
165 stars 87 forks source link

Update theme tests to remove P2 and use TwentyTwelve #336

Closed ernilambar closed 7 months ago

ernilambar commented 7 months ago

Replace P2 theme with TwentyTwelve in feature tests

Related https://github.com/wp-cli/wp-cli-tests/issues/200

danielbachhuber commented 7 months ago

@ernilambar Do you know what the random failure is?

ernilambar commented 7 months ago

@danielbachhuber Are you referring to this https://github.com/wp-cli/scaffold-command/actions/runs/8764755673/job/24143111683?pr=336 ? In PHP 8.4 tests are failing as WP does not support PHP 8.4 yet.

ernilambar commented 7 months ago

Earlier we had wp theme install p2 --activate. When I changed p2 to twentytwelve, like wp theme install twentytwelve --activate, there was some error as in older version of WP there is already TwentyTwelve installed. So I changed it to 

Given I try `wp theme install twentytwelve --activate --force`

I used try to suppress that error. May be adding --force would have been enough.

swissspidy commented 7 months ago

I think the failure is just because of the deprecation warnings emitted on PHP 8.4. They are fixed in WP trunk, but the test is installing the latest stable (6.5).

This will be resolved automatically once 6.6 is released this summer.

Note that PHP 8.4 tests are explicitly marked as allowed to fail because it's still in alpha (release is in November).

danielbachhuber commented 7 months ago

@swissspidy Thanks for the clarification!