search

wp-cli / scaffold-package-command

Scaffolds WP-CLI commands with functional tests, full README.md, and more.
MIT License
69 stars 20 forks source link

`wp scaffold package-tests . --force` will break test files #149

Closed miya0001 closed 7 years ago

miya0001 commented 7 years ago

Feature files were broken after I ran wp scaffold package-tests . --force like following. https://gist.github.com/miya0001/d17a036a2a82a86f293b459f4d7868d9

Also, a WP install is not working. I guess FeatureContext::copy_dir() isn't working as expected.

miya0001 commented 7 years ago

@wp-cli/committers

Hmm, I don't have any idea. 😓 Are there any mistake?

miya0001 commented 7 years ago

Ah, we can reproduce this problem with the nightly version of WP-CLI.

danielbachhuber commented 7 years ago

Did you mean to run wp scaffold package-tests ./ --force ?

miya0001 commented 7 years ago

@danielbachhuber

Yes I tried wp scaffold package-tests ./ --force too.

danielbachhuber commented 7 years ago

Huh. I just tried locally and it worked fine for me: https://github.com/wp-cli/scaffold-package-command/pull/150

miya0001 commented 7 years ago

I have same problem on the ubuntu with fresh install. I will look into tomorrow.

danielbachhuber commented 7 years ago

Oh. I see what's going on. https://github.com/wp-cli/wp-cli/pull/4391 is stripping Behat comments that it shouldn't be.

gitlost commented 7 years ago

Ah the @AfterSuite etc tags in FeatureContext?

danielbachhuber commented 7 years ago

@gitlost Yep. Creating a PR now.