search

wp-cli / scaffold-package-command

Scaffolds WP-CLI commands with functional tests, full README.md, and more.
MIT License
69 stars 20 forks source link

Fix Implode signature #191

Closed Lewiscowles1986 closed 3 years ago

Lewiscowles1986 commented 3 years ago

The following triggered an error locally...

return implode( $lines, "\n" );

By switching the operands so that glue comes first and collection second. I believe this might help this to work

This addresses a fundamental PHP error in the code. Unsure how this wasn't picked up on sooner.

schlessera commented 3 years ago

Thanks for the PR, @Lewiscowles1986 !