wp-cli / scaffold-package-command

Scaffolds WP-CLI commands with functional tests, full README.md, and more.
MIT License
69 stars 20 forks source link

Fix scaffolding paths #192

Closed Lewiscowles1986 closed 3 years ago

Lewiscowles1986 commented 3 years ago

Fixes #188

Approach:

Modify the file-paths copied

notation: source -> dest (vendor path omitted)

Note: Takes passing Travis-CI tests from 49 -> 51 with no new errors (that I've noticed, it's all still some composer version error)

Lewiscowles1986 commented 3 years ago

Here are three artifacts from a local build with the copied files. I need to run this on a different machine as it fails on composer after these are generated. I Do not believe this is due to these changes.

wp-cli-test-run-scaffold-package.feature.113-5fb65ebbdbded9.46320105.zip wp-cli-test-run-scaffold-package-readme.feature.59-5fb65eb14f3256.17474245.zip wp-cli-test-run-scaffold-package-readme.feature.84-5fb65eb29e5349.61293041.zip

schlessera commented 3 years ago

Closing this PR, as the changes in wp-cli-tests make it so these files are not needed I a new package repo anymore, so they also don't need to be copied.