wp-cli / scaffold-package-command

Scaffolds WP-CLI commands with functional tests, full README.md, and more.
MIT License
68 stars 19 forks source link

Error in Circle CI testing #239

Closed ernilambar closed 3 months ago

ernilambar commented 4 months ago

Bug Report

Describe the current, buggy behavior

wp scaffold package ernilambar/my-tool --dir=~/Temp/my-tool --skip-tests --skip-readme --skip-github --skip-install --force
wp scaffold package-tests ~/Temp/my-tool --ci=circle

For Circle, following files are added:

Adding these files along with the scaffolded files, Circle CI test is not successful.

Following error occurs:

Screenshot 2024-03-25 at 4 52 53 PM

Describe what you would expect as the correct outcome

Circle test should run properly for the scaffolded package.

ernilambar commented 3 months ago

I dug little deeper and tested several hit and trial for Circle CI test. I found out that this error is coming for wp-cli-test for v3. If I keep ^4 for wp-cli/wp-cli-tests, it is working fine.

Since version value of wp-cli/wp-cli-tests is coming dynamically from the argument, we should not be needing PR for the fix. But it would be nice if we could inform user to use version 4 of wp-cli/wp-cli-tests for Circle CI.

ernilambar commented 3 months ago

Closing issue.