search

wp-cli / search-replace-command

Searches/replaces strings in the database.
MIT License
57 stars 45 forks source link

Fix tests after change in WordPress trunk #195

Closed swissspidy closed 2 months ago

swissspidy commented 2 months ago

Improve the test case after https://core.trac.wordpress.org/changeset/58105 to address failures.

Simply removes the bits with the autoload value from the assertions.

The alternative would be to use a different value depending on the WP version but that seems overkill.

thelovekesh commented 2 months ago

Are these failing tests related to these changes?

swissspidy commented 2 months ago

Ah yes, looks like I need to fix the following assertions as well.

swissspidy commented 2 months ago

@thelovekesh should be fixed now

thelovekesh commented 2 months ago

It seems like the requests library is not PHP 8.4 compatible. We can probably ignore those failing tests for now.

swissspidy commented 2 months ago

@thelovekesh Please see https://github.com/wp-cli/wp-cli/issues/5946

PHP 8.4 is in alpha anyway and all 8.4 tests are marked as allowed to fail.