Add possibility to change the shell binary

wp-cli / shell-command

Opens an interactive PHP console for running and testing PHP code.

MIT License

20 stars 16 forks source link

Add possibility to change the shell binary #33

Closed villuorav closed 5 years ago

villuorav commented 6 years ago

Basically I have a shared hosting site, that has well,

[vhost68584ssh@procyon ~]$ which bash
/usr/local/bin/bash
[vhost68584ssh@procyon ~]$ /bin/bash
-bash: /bin/bash: No such file or directory

which means no shell-cookie-sugar-coated-sweetness for me :(

But as I am not actually a PHP person, I need some tips and pointers on how to get started with this functional testing point "3. Please make sure to include functional tests for your changes." Examples maybe :)

villuorav commented 6 years ago

@schlessera, let me know what you think (sorry, previous comment was under wrong account)

schlessera commented 6 years ago

~@villuorav I'm sorry, I don't really understand what the goal of this issue is. Are you trying to add a new functionality that lets you change the default shell of a user? There is already a Unix tool for that called chsh. Also, this would be out of scope for WP-CLI.~

~Can you explain in more detail what you're after?~

UPDATE: Oh, early in the morning for me. I completely missed that this is a PR and already comes with code.

I'll take a look at the actual code and get back to you.

schlessera commented 5 years ago

@villuorav Are you still up for working on this?

villuorav commented 5 years ago

Hi, sorry, completely forgot about this one

schlessera commented 5 years ago

Thanks for the PR, @villuorav !