search

wp-cli / shell-command

Opens an interactive PHP console for running and testing PHP code.
MIT License
20 stars 16 forks source link

Improve `wp shell` command description #9

Closed hearvox closed 7 years ago

hearvox commented 7 years ago

Related: /wp-cli/issues/4302

Improve wp shell command description in: https://github.com/wp-cli/shell-command/blob/master/src/Shell_Command.php https://github.com/wp-cli/shell-command/blob/master/README.md

Current description: Interactive PHP console.

New description: Opens an interactive PHP console for running and testing PHP code.

hearvox commented 7 years ago

@schlessera, if you have time, code you describe the process for making a requested change on a pull requested. I see this not added by Github:

Add more commits by pushing to the master branch on hearvox/shell-command.

So I'm guessing, rather than me closing this PR and making a new PR with requested, there's a way to make the change in my forked repo and merge it with this existing PR. But I can't find the GitHub doc on how to do that.

I made the change in my forked repo (removed trailing space on hearvox/shell-command). How do I get that change into this PR? thanks

schlessera commented 7 years ago

@hearvox The change was indeed added to this PR (look at the entry above your last comment).

In general, though, I'd recommend always creating a branch for doing a PR. This allows you to have more than one PR, and you can switch between them and add to them as needed.

schlessera commented 7 years ago

Authoring props: @hearvox & @ako80218