wp-cli / wp-cli-dev

🛠 WP-CLI development environment that allows for easy development across all packages
36 stars 35 forks source link

GitHub rate limiter causes issues during large events. #27

Closed NielsdeBlaauw closed 2 years ago

NielsdeBlaauw commented 2 years ago

Bug Report

Describe the current, buggy behavior During large events such as WordCamp Europe's contributor day, the install may fail because of rate limiting on the GitHub API.

This happens on https://github.com/wp-cli/wp-cli-dev/blob/main/.maintenance/clone-all-repositories.php#L15 when a lot of users are making GH API request from a shared network.

When this happens the error message is unclear and unrelated to the rate limiter, as it tries to parse the invalid response as a list of repositories and just crashes.

Describe how other contributors can replicate this bug Install a lot of times from the same API until running into the rate limiter.

Describe what you would expect as the correct outcome

If GitHub responds with a rate limiter response, handle it elegantly and post an error message explaining what is happening. The workaround is to use a mobile hotspot for installing. Better even would be adding the possibility of using a GitHub PAT. Provide a possible solution Use a mobile hotspot or tethered internet connection usually works around the rate limiter.