search

wp-cli / wp-cli-dev

🛠 WP-CLI development environment that allows for easy development across all packages
36 stars 36 forks source link

Make foreach-bundle a proper shell script #36

Closed szepeviktor closed 1 year ago

szepeviktor commented 2 years ago

☣️ This is highly theoretic: mostly written in GitHub editor.

szepeviktor commented 2 years ago

Should I include fetch-org?

danielbachhuber commented 1 year ago

@szepeviktor Out of curiosity, what functional benefit does this provide?

szepeviktor commented 1 year ago

@danielbachhuber This is the way one writes Bash scripts. This is the natural way. I try to add pointers in separate comments.

danielbachhuber commented 1 year ago

Great, thanks for clarifying @szepeviktor 😊

Let's get a second opinion from @schlessera

schlessera commented 1 year ago

Yes, the above sounds good to me. That script was just a quick hack I assembled and was never meant to be added as-is. But as we already have it included, we better make sure it is properly built.

szepeviktor commented 1 year ago

Thank you.