search

wp-cli / wp-config-transformer

Programmatically edit a wp-config.php file
MIT License
81 stars 25 forks source link

Avoid test failure with `assertNotSame` instead of `assertNotEquals` #41

Closed danielbachhuber closed 1 year ago

danielbachhuber commented 1 year ago

It looks like assertNotEquals is doing a truthy comparison that causes the test to fail.

See https://github.com/wp-cli/wp-cli/issues/5764

danielbachhuber commented 1 year ago

@fjarrett I'm glad it turned out to be an easy fix 😌

frankiejarrett commented 1 year ago

@danielbachhuber wondering if most assertEquals should also become assertSame?

danielbachhuber commented 1 year ago

@fjarrett Probably, but I don't really want to open that can of worms right now 😁