search

wp-e-commerce / WP-e-Commerce

WP eCommerce - The most popular independent eCommerce platform for WordPress
https://wpecommerce.org
GNU General Public License v2.0
215 stars 216 forks source link

Would the single product template benefit from a 'wpsc_product_after' filter? #108

Open benhuson opened 11 years ago

benhuson commented 11 years ago

Somewhere to hook into to add product rater, facebook button, also bought etc that usually come after the product information.

There is a 'wpsc_product_form_fields_end' but this is still within the form. It feels like it would benefit from one after where the things above are currently hardcoded.

Weeb commented 11 years ago

+1 for this. Also get rid of Facebook, Sharethis, Rating and Comments from core?

JustinSainton commented 11 years ago

Thanks for the input, Weeb! Good thoughts, for sure. Getting rid of anything from core should be a separate issue from this, though. However - +1 for Facebook, ShareThis and Ratings - -1 to Comments. Comments should be re-purposed as proper product reviews. But we should definitely be doing something different there.

As far as the new hook goes - I'm not opposed at all. I think it actually makes great sense.

We're in a bit of an awkward stage for our current core theme, given the pending theme engine @garyc40 is working on. IIRC, the new theme engine follows core standards a bit better in the action/filter concept - I believe it just had template tags (like get_header, the_title, wp_head, etc.) rather than putting the filters/actions directly in the theme. And inside those functions, go the filters/actions. Much better idea.

As we're considering things like this - we need to keep in mind how we communicate these to the majority of our users who have already copied the original theme files into their active theme folder without making these changes.

We need a good way to document version-to-version changes in the core theme file and educate people about how to make those changes if they've already copied the files to their active theme folder (which we nag them to do). Also need to check with Gary to see if that is the way things will work in the new theme engine. Speaking to the 'wpsc_product_form_fields_end' - from time to time I hear people ask why @leewillis77's Product Options plugin doesn't work - when in fact, it works fine - they just have an old version of the core theme file in their active folder.

All food for thought.

benhuson commented 11 years ago

Yes, version-to-version theme changes is always a tricky one - I guess it just needs a dedicated theme changes post for each release.

Maybe let's hold of adding this filter until we have a clearer idea how the new theme engine will work and what filters it will have inherently in it.