In Theme Engine v1 WPEC_Fancy_Notifications JS component, the 'add to basket' loading animation is hidden even when fancy notifications is not active in admin settings.
This PR only adds the Fancy Notifications JS if the Presentation Options is selected in the admin.
This PR is only tested with Theme Engine v1.
Future-wise I'm not sure in TE2 wether we should still be loading the JS to despatch add to basket events for Fancy Notifications, just removing the listeners?
Having said that, there is a lot of traction at the moment on the WP Trac ticket for adding JavaScript actions and filters to core. Once something like that makes it into core it would make more sense to build the "add to basket" event using that framework so it is hackable via JS. https://core.trac.wordpress.org/ticket/21170
Fix for issue #2336:
In Theme Engine v1
WPEC_Fancy_NotificationsJS component, the 'add to basket' loading animation is hidden even when fancy notifications is not active in admin settings.This PR only adds the Fancy Notifications JS if the Presentation Options is selected in the admin.
This PR is only tested with Theme Engine v1.
Future-wise I'm not sure in TE2 wether we should still be loading the JS to despatch add to basket events for Fancy Notifications, just removing the listeners?
Having said that, there is a lot of traction at the moment on the WP Trac ticket for adding JavaScript actions and filters to core. Once something like that makes it into core it would make more sense to build the "add to basket" event using that framework so it is hackable via JS. https://core.trac.wordpress.org/ticket/21170