search

wp-e-commerce / WP-e-Commerce

WP eCommerce - The most popular independent eCommerce platform for WordPress
https://wpecommerce.org
GNU General Public License v2.0
216 stars 216 forks source link

Rip Out All Font Sizes / Styling in Front End CSS #296

Open pippinsplugins opened 11 years ago

pippinsplugins commented 11 years ago

Of all things I have disliked about WPEC over the years, the CSS styling on the front end is the worst of them. I don't necessarily mean the layouts or spacing, but the font styles.

A plugin has no business controlling fonts, font sizes, font styles, etc.

In order to make WPEC integrate more seamlessly with themes, I'm proposing that we completely rip out all instances of font-size, font-family, line-height, etc, except with explicitly necessary.

This, for example, is what a product looks like out of the box with Twenty Thirteen: Screenshot from 2013-03-15 21:00:21

This is what it should look like: Screenshot from 2013-03-15 21:02:02

(note I removed the product image place holder, as described in #295)

millsweb commented 11 years ago

YES YES YES - the biggest waste of time I ever have with installing wp ecommerce is UNDOING all the styling it tries to impose on my theme. I have to weed through the wp ecommerce stylesheet and REMOVE rules that it arbitrarily places on things for no reason. Things are indented, given padding, font styles, arbitrary sizes, and it actually looks cleaner and better when you weed all that unnecessary css crap out.

Sure - leave classes in the html output so we can mess with it if we want, just scrap all the unnecessary rules you have connected to them.

Here is something worth knowing - I could cut an hour of my install time if you guys let the theme do the job and cut all of that out of your css so I dont have to each time.

millsweb commented 11 years ago

p.s. I think pippinsplugins has been very kind to you in their example. There are many dogs breakfast aspects that arent shown.

instinct commented 11 years ago

This is exactly what Gary is doing in 3.9 - by the end of the week the 3.9 branch should be ready for people to start testing.

To sweeten the deal we're also looking at creating a new e-commerce skeleton theme based on underscores... which is naturally about as WordPress friendly as you can get. As soon as that is ready we'll start talking about it here.

Best, Dan

On 19/03/2013, at 9:39 AM, millsweb notifications@github.com wrote:

YES YES YES - the biggest waste of time I ever have with installing wp ecommerce is UNDOING all the styling it tries to impose on my theme. I have to weed through the wp ecommerce stylesheet and REMOVE rules that it arbitrarily places on things for no reason. Things are indented, given padding, font styles, arbitrary sizes, and it actually looks cleaner and better when you weed all that unnecessary css crap out.

Sure - leave classes in the html output so we can mess with it if we want, just scrap all the unnecessary rules you have connected to them.

Here is something worth knowing - I could cut an hour of my install time if you guys let the theme do the job and cut all of that out of your css so I dont have to each time.

— Reply to this email directly or view it on GitHub.

pippinsplugins commented 11 years ago

@instinct That's great to hear!

JustinSainton commented 11 years ago

That said, even with 3.9 out, we'll still have the pre-3.9 engine for back compat in core - and I think we can improve upon the core theme in these primarily aesthetic ways. Primarily because they don't really require that we worry too much about upgrade routines - they're just nice to have. I think this makes sense for 3.8.12.

instinct commented 11 years ago

How do we get 3.9 beta testers already :P

Sent from my iPhone

On 4/05/2013, at 9:43 AM, JustinSainton notifications@github.com wrote:

That said, even with 3.9 out, we'll still have the pre-3.9 engine for back compat in core - and I think we can improve upon the core theme in these primarily aesthetic ways. Primarily because they don't really require that we worry too much about upgrade routines - they're just nice to have. I think this makes sense for 3.8.12.

— Reply to this email directly or view it on GitHub.

JustinSainton commented 11 years ago

@pippinsplugins You want to submit a PR for this?

garyc40 commented 11 years ago

Not totally related, but the new theme engine learnt from this mistake. If anyone's interested in testing: #78

Still need to fix this in the old theme engine though.

JeffPyeBrook commented 10 years ago

Related to release 3.9.0 and the new theme engine

instinct commented 10 years ago

I might be wrong here but my understanding is that essentially 3.9 will come shipped with the new Theme engine AND the old theme engine - @garyc40 designed this so that we can maintain backwards compatibility until there are plenty of good new 3.9 themes in the market for our users to use.

The two 3.9 use cases are:

1) So when somebody upgrades to 3.9 they will have to click a button to activate / start using the new Theme engine

or

2) When somebody installs the 3.9 on a fresh WP install they will get the new Theme engine will just work naturally.

Best, Dan

On Sat, Mar 8, 2014 at 12:24 PM, Jeff @ Pye Brook notifications@github.comwrote:

Related to release 3.9.0 and the new theme engine

Reply to this email directly or view it on GitHubhttps://github.com/wp-e-commerce/WP-e-Commerce/issues/296#issuecomment-37079065 .

Dan Milward

M +64 21 449 901

178 Willis Street - Wellington CBD - Wellington 6011 - New Zealand www.getshopped.org - www.gamefroot.com