Open JustinSainton opened 11 years ago
This is a template issue. It only tests the OUT of stock function if we are using the Add to Cart button. (sigh)
If this is a Buy Now case, then the wpsc_buy_now_button function outputs the Buy Now button. I am recommending that we add a test at the top of the wpsc_buy_now_button function that just notes that the product is out of stock, rather than providing a button to take them to Paypal.
This would be best solved by changing the template logic but we all know the legacy issues that creates.
And the fact that Gary is soon to launch a 3.9 beta for general public use...
d
On 13/05/2013, at 11:24 AM, Tom Ransom notifications@github.com wrote:
This is a template issue. It only tests the OUT of stock function if we are using the Add to Cart button. (sigh)
If this is a Buy Now case, then the wpsc_buy_now_button function outputs the Buy Now button. I am recommending that we add a test at the top of the wpsc_buy_now_button function that just notes that the product is out of stock, rather than providing a button to take them to Paypal.
This would be best solved by changing the template logic but we all know the legacy issues that creates.
— Reply to this email directly or view it on GitHub.
@1bigidea - I think that's a fine idea. PR welcomed. To note (as far as I know), 3.9 being available doesn't change the reality that a LOT of people won't be using it for awhile, even after 3.9. So changes like this, that don't require people to upgrade their themes, and don't require any changes to theme files at all - these are wins for us to pursue.
I just want to add that this feature does not even work in regular non-out-of-stock situation.
These are my findings just now on 3.8.14.3
On products page IF a product has variations Clicking the buy now button does nothing (great) On individual products page:
I think we just need a better handling of Buy now and variations
Okay, so it is my goal to fix the out of stock issue before 3.9 launches. If I don't update in the channel every couple days or on this ticket, please feel free to bump this. I don't want to forget. If someone else wants to handle the ux that would be awesome.
Fixed the issue of the Buy Now button being enabled when a product is out of stock. the rest can wait for a future release.
See bfd1cc1d4464d0b18d555dfbfaeefde1f91bb0b8
You're taken to a page like this
In the situation that a product is already out of stock when a user lands on a page, the "Product is out of stock" message should be there (I'm fine with the same one shown if the "Show stock availability" option is checked).
If it becomes out of stock after the page has loaded, we should also be checking this when they Buy and redirect back to the page instead of PayPal.