search

wp-e-commerce / WP-e-Commerce

WP eCommerce - The most popular independent eCommerce platform for WordPress
https://wpecommerce.org
GNU General Public License v2.0
216 stars 216 forks source link

WP e-Commerce needs "About" and "Credits" pages #618

Open garyc40 opened 11 years ago

garyc40 commented 11 years ago

It's time.

garyc40 commented 11 years ago

In this PR I haven't done redirection to these pages after plugin activation / upgrade yet.

Wondering if this is considered best practices? Should we just make those pages visible under admin menu by default? What happens if WPEC is enabled along with multiple other plugins and each have their own about pages to redirect to?

Minor points but could be confusing.

instinct commented 11 years ago

I know buddypress and bbpress do it on install. But I don't know about on upgrade.

What do those plugins do?

Sent from my iPhone

On 27/08/2013, at 2:18 AM, Gary Cao notifications@github.com wrote:

In this PR I haven't done redirection to these pages after plugin activation / upgrade yet.

Wondering if this is considered best practices? Should we just make those pages visible under admin menu by default? What happens if WPEC is enabled along with multiple other plugins and each have their own about pages to redirect to?

Minor points but could be confusing.

— Reply to this email directly or view it on GitHub.

pippinsplugins commented 11 years ago

EDD does the the about/welcome page as well, just like bbPress. We took it from bbPress.

instinct commented 11 years ago

I think we should take ours from bbPress too. I'm not wanting to spend time recreating the wheel... or even spend time thinking about recreating the wheel. Just do what bbPress does for now :)

JustinSainton commented 10 years ago

Worth noting that Advanced Custom Fields also redirects automatically to a welcome page on plugin activation. Worth investigating what happens on bulk activation.

JustinSainton commented 10 years ago

Moving to future release.