wp-graphql / acf.wpgraphql.com

https://acf.wpgraphql.com
1 stars 1 forks source link

AcfFieldTypeSettings Block #7

Closed jasonbahl closed 7 months ago

jasonbahl commented 9 months ago

AC

When an "AcfFieldTypeSettings" Block is added to content, it will render the selected settings in a list or table

Notes:

I was thinking something similar to how settings are output here: https://www.advancedcustomfields.com/resources/email/#settings. Could be a table or list, whatever seems to look best. WordPress.org documents things like this: https://developer.wordpress.org/reference/functions/get_posts/#parameters

josephfusco commented 8 months ago

"Name" and "Description" are wired up, however the current table implementation doesn't leave much room for another column to show "Impact on WPGraphQL"

If we still wish to include that here, maybe we tuck that content into a popover type design token 🤔

jasonbahl commented 8 months ago

@josephfusco if we only had 1 field visible, I'd prefer to have the "Impact on WPGraphQL" as the visible one as that's what we're ultimately trying to document.

josephfusco commented 8 months ago

@jasonbahl How do we wish to handle the empty state for a setting?

Potential solutions for handling similar scenarios:

jasonbahl commented 8 months ago

@josephfusco lets hide the row for now. Can revisit if that feels weird

josephfusco commented 8 months ago

Image

I omitted "ACF field name" for now as it looked weird to me. Description is set for "screen readers only" within the popover since there was redundant text in a lot of the screenshots.