Closed jasonbahl closed 7 months ago
"Name" and "Description" are wired up, however the current table implementation doesn't leave much room for another column to show "Impact on WPGraphQL"
If we still wish to include that here, maybe we tuck that content into a popover type design token 🤔
@josephfusco if we only had 1 field visible, I'd prefer to have the "Impact on WPGraphQL" as the visible one as that's what we're ultimately trying to document.
@jasonbahl How do we wish to handle the empty state for a setting?
Potential solutions for handling similar scenarios:
N/A
, null
, none
, etc@josephfusco lets hide the row for now. Can revisit if that feels weird
I omitted "ACF field name" for now as it looked weird to me. Description is set for "screen readers only" within the popover since there was redundant text in a lot of the screenshots.
AC
When an "AcfFieldTypeSettings" Block is added to content, it will render the selected settings in a list or table
Notes:
I was thinking something similar to how settings are output here: https://www.advancedcustomfields.com/resources/email/#settings. Could be a table or list, whatever seems to look best. WordPress.org documents things like this: https://developer.wordpress.org/reference/functions/get_posts/#parameters