wp-graphql / wp-graphql-acf

WPGraphQL for Advanced Custom Fields
https://wpgraphql.com/acf
626 stars 123 forks source link

Required parameter deprecation notice PHP8 #303

Closed KevinBatdorf closed 11 months ago

KevinBatdorf commented 2 years ago

PHP will show a deprecated notice for when an optional parameter is defined before a required one.

https://github.com/wp-graphql/wp-graphql-acf/blob/develop/src/location-rules.php#L209

I have debug mode on with notices printed to the screen while developing, so it breaking the request.

Thanks

jasonbahl commented 11 months ago

closed by #313

p.s. this repo will be archived in the not-too-distant future in favor of the re-architected plugin over here: https://github.com/wp-graphql/wpgraphql-acf and the new version will be released on the WordPress.org repo and is the version we'll be supporting long term. 🙏🏻