wp-graphql / wp-graphql-acf

WPGraphQL for Advanced Custom Fields
https://wpgraphql.com/acf
627 stars 123 forks source link

Revert "Returning false for true_false values" #334

Closed jasonbahl closed 2 years ago

jasonbahl commented 2 years ago

Reverts wp-graphql/wp-graphql-acf#304

I'm reverting this as I need to think through this better.

If a field is not set, it should be null.

If the field is set, and the value is true, it should be true. If isset and the value is false, it should be false.

A non-set value should return null, because it hasn't been set yet. Returning false would be a mistake, because the value hasn't been set to false, it just hasn't been set at all yet.