wp-graphql / wp-graphql

:rocket: GraphQL API for WordPress
https://www.wpgraphql.com
GNU General Public License v3.0
3.63k stars 440 forks source link

ACF Sections for Flexible content not showing in the IDE since 1.7+ #2370

Closed nhankla-kl closed 1 year ago

nhankla-kl commented 2 years ago

Found a bug in the updated WpGraphQL 1.7.1 and ACF We use Flexible Fields a lot and the updated WPGraphQL does not show the flexible fields in the scheme: Vs 1.6.10

1.6.10 Screen Shot 2022-03-08 at 9 40 55 AM

1.7+ image

rodrigo-arias commented 2 years ago

I have seen this also with ACF relationship fields https://github.com/wp-graphql/wp-graphql-acf/issues/319

jensmercedesbenz commented 2 years ago

We're locked to wp-graphql 1.6.12 (where the schema browser is called Explorer) due to this as well.

I'd just like to confirm that the connections are indeed there and functioning but the schema isn't available for browsing using GraphiQL (in 1.5.8 where the function is renamed Query Composer (if 1.5.8 is the version you're bundling I'm not sure, found that reference in your root package.json) as before.

Thanks for looking in to it!

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rodrigo-arias commented 2 years ago

Leaving a comment here, as this is still an issue.

jensmercedesbenz commented 2 years ago

Described issue still present in WPGraphQL 1.9.1

@justlevine What does the status: awaiting reviewer response mean/refer to?

justlevine commented 2 years ago

@jensmercedesbenz in this context, it means someone with a deeper understanding of the codebase needs to figure what's causing this issue, so it can be addressed.

Everyone is encouraged to do their own sleuthing to help us get to the bottom of this and ship a fix, the label just lets committees/maintainers know this could benefit from their 👀

jensmercedesbenz commented 1 year ago

Described issue still present in WPGraphQL 1.10.0 and with latest update to WPGraphQL for Advanced Custom Fields 0.6.1

I've tried doing some poking around on my own but without any real progress. Any good ideas or pointers on a good entry point or process to take on such an endeavour @justlevine ?

justlevine commented 1 year ago

@jensmercedesbenz I'm personally not all that familiar with wp-graphql-acf.

In general, issues like these (i.e. missing GraphQL fields when upgrading to v1.7.0+) are due to the way types -especially those on an interface/union - get lazy-loaded.

Depending on the specific implementation in the extension, the solution is usually to change the logic used to register the field/type, or if that fails (since it comes at a performance cost), to set the relevant config to 'eagerlyLoadType' => true.

Hope that helps give you at least some direction.

@jasonbahl should we move this issue to the ACF repo, so it doesn't get overlooked? (I don't have the necessary permissions or id do it myself).

rodrigo-arias commented 1 year ago

@justlevine maybe not be titled the same, but I think this ACF issue started at the same time so they may be related.

jasonbahl commented 1 year ago

This was fixed in release 1.13.0