wp-graphql / wpgraphql-acf

Re-architecture of WPGraphQL for ACF
GNU General Public License v3.0
83 stars 12 forks source link

Can't move attendees in Events Calendar due to fatal errors caused by $hook_suffix type #180

Closed craigwilcox closed 7 months ago

craigwilcox commented 7 months ago

Description

This is a copy of the issue in WPGraphQL: https://github.com/wp-graphql/wp-graphql/issues/3056

Once the issue is fixed in WPGraphQL, the issue pops up in WPGraphQL for ACF as follows when trying to move attendees in Events Tickets Plus:

Steps to reproduce

  1. Enable The Events Calendar, The Events Calendar Pro, Event Tickets and Event Tickets Plus.
  2. Make a class with a ticket.
  3. Sign up for the class.
  4. Go to Attendees for that class.
  5. Select an Attendee and use the Bulk action of "Move".

PHP or JSON export of the ACF Field Group(s)

No response

Additional context

In speaking with Jason, this can be fixed by changing the file mentioned above, plus https://github.com/wp-graphql/wpgraphql-acf/blob/develop/src/Admin/PostTypeRegistration.php#L169-L172 to use ?string $hook_suffix instead of string $hook_suffix.

WPGraphQL Version

1.21.0

WPGraphQL For ACF Version

2.1.2

ACF (Advanced Custom Fields) Version. Free or Pro?

Pro

WordPress Version

6.4.3

PHP Version

7.4.30

Additional enviornment details

No response

Please confirm that you have searched existing issues in the repo.

Please confirm that you have disabled ALL plugins except for WPGraphQL, WPGraphQL For ACF, ACF, etc.