wp-graphql / wpgraphql-acf

Re-architecture of WPGraphQL for ACF
GNU General Public License v3.0
82 stars 12 forks source link

Clone Fields seem to be broken with latest release #237

Open infn8 opened 3 weeks ago

infn8 commented 3 weeks ago

Description

I am using a clone field and it has been working, but updating to the latest version of the plug-in breaks it

Steps to reproduce

PHP or JSON export of the ACF Field Group(s)

No response

Additional context

No response

WPGraphQL Version

Version 1.28.0

WPGraphQL For ACF Version

2.4.1

ACF (Advanced Custom Fields) Version. Free or Pro?

pro Version 6.3.5

WordPress Version

6.6.1

PHP Version

PHP 8.2

Additional enviornment details

No response

Please confirm that you have searched existing issues in the repo.

Please confirm that you have disabled ALL plugins except for WPGraphQL, WPGraphQL For ACF, ACF, etc.

josephfusco commented 3 weeks ago

Hey @infn8, can you please provide an export of your site's ACF field groups? This will allow us to better understand your setup.

Which version of WPGraphQL for ACF was last working for you prior to updating to the latest (currently 2.4.1)?

infn8 commented 3 weeks ago

2.2.0 was the last working version. I have also uploaded a walk through video here:

https://infn8.notion.site/Bug-Report-for-WPGraphQL-for-ACF-Version-2-4-1-39617cd8674a43868bd3293b568861c1

here is a zip of my ACF JSON folder in my theme.

the field in question is field_6666fb73f66d0 in group_6666fb7162288.json which clones field_6666fbc6f66d1 in group_6666fb7162288.json

the graphQL that DID work in version 2.2.0 is:

query GetPage($databaseId: ID!, $asPreview: Boolean = false) {
  page(id: $databaseId, idType: DATABASE_ID, asPreview: $asPreview) {
    title
    content
    whereToBuyDetails {
      featureTileDetails {
        title
        subtitle
        pretitle
        miceType
        backgroundColor
        image {
          node {
            sourceUrl
            srcSet
            uri
          }
        }
      }
    }
  }
  locations(first: 999, where: {hideEmpty: false}) {
    nodes {
      uri
      slug
      name
    }
  }
  retailers(first: 999) {
    nodes {
      id
      title
      terms {
        nodes {
          ... on Location {
            name
            slug
          }
        }
      }
      retailerDetails {
        retailUrl
        retailerLogo {
          node {
            mediaItemUrl
            srcSet
          }
        }
      }
    }
  }
}

acf-json.zip

infn8 commented 3 weeks ago

the error was

{
  "errors": [
    {
      "message": "Cannot query field \"featureTileDetails\" on type \"WhereToBuyDetails\".",
      "extensions": {
        "category": "graphql"
      },
      "locations": [
        {
          "line": 6,
          "column": 7
        }
      ]
    }
  ],
  "extensions": {
    "debug": [],
    "queryAnalyzer": {
      "keys": "5305d35ebb090a5f4174edefcf4cd72c2570c5da3215a0a64b8e2dab16e3d7b5 graphql:Query operation:GetPage list:location list:retailer",
      "keysLength": 124,
      "keysCount": 5,
      "skippedKeys": "",
      "skippedKeysSize": 0,
      "skippedKeysCount": 0,
      "skippedTypes": []
    }
  }
}
elliott-w commented 2 weeks ago

@infn8 this is probably the same issue as #233. Can you try the following:

In your Where to Buy Details field group (group_6666fc462d63a), wrap the Feature Tile Details clone field (field_6666fc47a48e3) in a group field. Also ensure that your clone field display is set to Seamless