wp-graphql / wpgraphql-acf

Re-architecture of WPGraphQL for ACF
GNU General Public License v3.0
88 stars 12 forks source link

Suggestion: Recommend `phpsab` for VSCode #52

Open justlevine opened 1 year ago

justlevine commented 1 year ago

What problem does this address?

Both ikappas.phpcs and persoderlind.vscode-phpcbf have been abandonded since 2018 and have many known issues with VSCode itself and even more on non Mac devices.

Additionally, why install 2 plugins when one will suffice?

What is your proposed solution?

I recommend ValeryanM.vscode-phpsab, which is the successor of the currently mentioned plugins.

A .vscode/settings.json config can even be included in the repo:

{
    "phpsab.executablePathCBF": "vendor/bin/phpcbf",
    "phpsab.executablePathCS": "vendor/bin/phpcs"
}

What alternatives have you considered?

No response

Additional Context

https://tommcfarlin.com/php-sniffer-for-visual-studio-code/

jasonbahl commented 1 year ago

@justlevine feel free to PR this.